feat: improve error and warning messages in overlay #4087
+149
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
force-pushed
the
improve-overlay-message
branch
from
b0d7246 to
478b963
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4087 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 16 16
Lines 1593 1593
Branches 596 596
=======================================
Hits 1470 1470
Misses 114 114
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yes, WIP on tests |
snitin315
force-pushed
the
improve-overlay-message
branch
from
478b963 to
b78547a
Compare
snitin315
requested review from
anshumanv,
hiroppy and
knagaitsev
as code owners
|
Yes, can you suggest some test cases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Refers #3689
improve error and warning messages in overlay.
Breaking Changes
None
Additional Info
No